Possibility to use custom allocators for nodes retrieved from cursors and queries #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObserverOfTime
requested changes
Dec 11, 2024
src/test/java/io/github/treesitter/jtreesitter/TreeCursorTest.java
Outdated
Show resolved
Hide resolved
Emmeral
force-pushed
the
CustomNativeMemoryScope
branch
from
0a6adce to
f60959d
Compare
Contributor
Author
|
I implemented the requested changes. Could you please re-review @ObserverOfTime ? |
ObserverOfTime
force-pushed
the
CustomNativeMemoryScope
branch
from
c86f5ae to
df9050d
Compare
ObserverOfTime
force-pushed
the
CustomNativeMemoryScope
branch
from
df9050d to
e7960ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Allows to use a custom
SegmentAllocatorwhen retrieving node instances from cursors and queries. This allows for using the nodes even after the cursor / query has been closed. Also it gives the caller the opportunity to clear the memory of a node without closing the cursor / query in case a lot of nodes are retrieved without closing the cursor / query.Note: This PR also removes the cached java node object in the
TreeCursorclass as we do now longer control the lifetime of its native memory. I hope this is ok as recreating it (in case somebody retrieves the same node twice) should not be that expensive.